gpSP0.8 kai 2.6 (GBA Emulator for PSP)

**PSPCulture** · December 14th, 2006, 09:01

Originally Posted by Exophase

Which is of course makes the code style inconsistent and is actually really disrespectful. When you work on someone else's project you should use their coding style in the code YOU write, but arbitrarily changing the style of the code THEY write is a slap in the face. Of course, I don't expect the non-programmers here to understand this, especially SpacemanSpiff who will just call me a jerk and go back to praising a release where he doesn't even know what was changed. Whatever.

So lets get this straight, you released the source code for gPSP and someone has taken that source, changed a bit of bracketing in the code, removed some debug code, added some lines to a config file (most of which were already there) and then released it to the public?

If I were you I'd be withdrawing the source from the next release. If someone is going to modify your source code while you are still working on the project, they should be liasing with you on what changes they have made, and whether it moves the project forward in a suitable direction.

If source code is released, and someone works on that source code and finds a major efficiency gain, that information should be passed back to the original author, so it can be applied to the official development.

The only time a third party should start releasing their own version of a program is when the orignal author has ceased development on the software.

That, of course, is my opinion on the matter. I may be wrong, but if someone at work did that to me on my code that I am still developing, I'd be having a quiet word in their ear. Help and advice yes, underhand changing and releasing of code, no. Maybe its the 10+ years of software development that have given me an undue sense of right and wrong when it comes to source etiquette.

**240-185** · December 14th, 2006, 10:42

You missed the point .

I don't think that deleting a "Return" in the code improves efficiency. (Sorry, I'm French, and I don't know how to turn it in English

) In fact, that DOES NOT improve efficiency.

What Exophase regrets is that his own code is modified for some weird esthetical reasons.

Expohase> Can you have a look once more in the code of Kai 2.6 in order to see why it can't save the button settings ? (In the official 0.8 version, I set the menu button with SQUARE and the FastForward feature with TRIANGLE, and this Kai version does not keep these :'()

**Veskgar** · December 14th, 2006, 12:17

Originally Posted by PSPCulture

If source code is released, and someone works on that source code and finds a major efficiency gain, that information should be passed back to the original author, so it can be applied to the official development.

The only time a third party should start releasing their own version of a program is when the orignal author has ceased development on the software.

Great post man. That is exactly how it seems Exophase feels on the matter. And its how a lot of other fans of gpSP feel as well. So it is really great to see another coder comment like you have on this.

I don't know for sure, but these kai releases could be slowing the official gpSP down a tad. And nobody wants that.

**sheng** · December 14th, 2006, 13:29

Originally Posted by Exophase

He also commented out a bunch of variables I use for debugging, and some ++'s in very noncritcal places, maybe thinking he was optimizing the emulator somehow. And more aggrivating, he arbitrarily changed my bracket style in a few places, for instance:

if(dispstat & 0x10)
irq_raised |= IRQ_HBLANK;
}
else
{

...

if(update_input())
return execute_cycles;

In 0.8, now

if(dispstat & 0x10)
irq_raised |= IRQ_HBLANK;
} else {

...

if (update_input()) {
return execute_cycles;
}

>.> OMG I can't believe that he made changes like that... in what way will it improve the emulator? lesser lines XD I don't think so... anyway... great to hear from you... I may look into the code see if I can pick up anything... ^_^

240-185: it may be the code that are been modded have distroied a loop that was there before... it should be a easy fix... but I don't think you'll need to bother much about it cause most likely the guy modding now have addressed it and have another release later...

**Oops** · December 14th, 2006, 13:45

Originally Posted by 240-185

You missed the point . [...] What Exophase regrets is that his own code is modified for some weird esthetical reasons. [..]

Maybe you should re-read carefully Exophase interventions about this, because obviously you missed the whole point.

**Lodis** · December 14th, 2006, 14:43

Originally Posted by Oops

Maybe you should re-read carefully Exophase interventions about this, because obviously you missed the whole point.

Exophase has said time and time again that he wishes anyone who modifies the source to contact him first and basically to show a bit of respect. Repeatedly, respect has not been shown and he has had to go through code to see what has been changed only to find that either he had already made these changes or the changes didn't actually do anything significant or causes problems elsewhere. In my opinion, the next versions of gpSP should be made closed source since it seems no one is listening to his very basic requests. Perhaps that will make them learn a lesson to be honest.

**Ramza042** · December 14th, 2006, 22:20

Originally Posted by homemade

Here a list of changes since he started:

-Faster save states
-All four Jap Super robot wars game works
-Scurge Hive works
-demikids works
-ability 2 change config for analog
-fixed a bug which made shining force placed an invisible wall in front of the church at the start of the game and i couldn't continue

if he fixed that shining force bug, it sure could have fooled me. I still get stuck in the church. :rofl:

Oh yea, and final fantasy 5 runs like crap now too without a frameskip of like 9. Which version you using, man? the eloader or the 1.0/1.5?